Reland [Clang][Cmake] fix libtool duplicate member name warnings #133850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-hlsl @llvm/pr-subscribers-clang Author: Farzon Lotfi (farzonl) Changesfixes #133199 The fix to reland was moving That change means that the files in PR #132252 Created a second file that shared <TargetName>.cpp in clang/lib/CodeGen/CMakeLists.txt For example There were two AMDGPU.cpp's one in TargetBuiltins and the other in Targets. Even though these were in different directories libtool warns that it might not distinguish them because they share the same base name. There are two potential fixes. The easy fix is to rename one of them and keep one cmake file. That solution though doesn't future proof this problem in the event of a third <TargetName>.cpp and it seems teams want to just use the target name The alternative fix is to seperate the cmake files into their own sub directories as static libs. Full diff: https://github.com/llvm/llvm-project/pull/133850.diff 4 Files Affected:
diff --git a/clang/lib/CodeGen/CMakeLists.txt b/clang/lib/CodeGen/CMakeLists.txt
index ebe2fbd7db295..2bf32a6b9d8aa 100644
--- a/clang/lib/CodeGen/CMakeLists.txt
+++ b/clang/lib/CodeGen/CMakeLists.txt
@@ -116,45 +116,10 @@ add_clang_library(clangCodeGen
PatternInit.cpp
SanitizerMetadata.cpp
SwiftCallingConv.cpp
- TargetBuiltins/ARM.cpp
- TargetBuiltins/AMDGPU.cpp
- TargetBuiltins/Hexagon.cpp
- TargetBuiltins/NVPTX.cpp
- TargetBuiltins/PPC.cpp
- TargetBuiltins/RISCV.cpp
- TargetBuiltins/SPIR.cpp
- TargetBuiltins/SystemZ.cpp
- TargetBuiltins/WebAssembly.cpp
- TargetBuiltins/X86.cpp
TargetInfo.cpp
- Targets/AArch64.cpp
- Targets/AMDGPU.cpp
- Targets/ARC.cpp
- Targets/ARM.cpp
- Targets/AVR.cpp
- Targets/BPF.cpp
- Targets/CSKY.cpp
Targets/DirectX.cpp
- Targets/Hexagon.cpp
- Targets/Lanai.cpp
- Targets/LoongArch.cpp
- Targets/M68k.cpp
- Targets/MSP430.cpp
- Targets/Mips.cpp
- Targets/NVPTX.cpp
- Targets/PNaCl.cpp
- Targets/PPC.cpp
- Targets/RISCV.cpp
- Targets/SPIR.cpp
- Targets/Sparc.cpp
- Targets/SystemZ.cpp
- Targets/TCE.cpp
- Targets/VE.cpp
- Targets/WebAssembly.cpp
- Targets/X86.cpp
- Targets/XCore.cpp
VarBypassDetector.cpp
-
+
DEPENDS
vt_gen
intrinsics_gen
@@ -170,4 +135,16 @@ add_clang_library(clangCodeGen
clangFrontend
clangLex
clangSerialization
+ clangCodeGenTargetBuiltins
+ clangCodeGenTargets
+ )
+
+ target_include_directories(clangCodeGen
+ PUBLIC
+ ${CMAKE_CURRENT_SOURCE_DIR}
+ ${CMAKE_CURRENT_SOURCE_DIR}/TargetBuiltins
+ ${CMAKE_CURRENT_SOURCE_DIR}/Targets
)
+
+ add_subdirectory(TargetBuiltins)
+ add_subdirectory(Targets)
diff --git a/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp b/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp
index b56b739094ff3..577fee05d4af6 100644
--- a/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp
+++ b/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp
@@ -1,4 +1,4 @@
-//===------- AMDCPU.cpp - Emit LLVM Code for builtins ---------------------===//
+//===------- AMDGPU.cpp - Emit LLVM Code for builtins ---------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
diff --git a/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt b/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt
new file mode 100644
index 0000000000000..76be68a11d02a
--- /dev/null
+++ b/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt
@@ -0,0 +1,14 @@
+include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
+
+add_clang_library(clangCodeGenTargetBuiltins STATIC
+ ARM.cpp
+ AMDGPU.cpp
+ Hexagon.cpp
+ NVPTX.cpp
+ PPC.cpp
+ RISCV.cpp
+ SPIR.cpp
+ SystemZ.cpp
+ WebAssembly.cpp
+ X86.cpp
+)
diff --git a/clang/lib/CodeGen/Targets/CMakeLists.txt b/clang/lib/CodeGen/Targets/CMakeLists.txt
new file mode 100644
index 0000000000000..531a9461b7201
--- /dev/null
+++ b/clang/lib/CodeGen/Targets/CMakeLists.txt
@@ -0,0 +1,30 @@
+include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
+
+add_clang_library(clangCodeGenTargets STATIC
+ PARTIAL_SOURCES_INTENDED
+ AArch64.cpp
+ AMDGPU.cpp
+ ARC.cpp
+ ARM.cpp
+ AVR.cpp
+ BPF.cpp
+ CSKY.cpp
+ Hexagon.cpp
+ Lanai.cpp
+ LoongArch.cpp
+ M68k.cpp
+ MSP430.cpp
+ Mips.cpp
+ NVPTX.cpp
+ PNaCl.cpp
+ PPC.cpp
+ RISCV.cpp
+ SPIR.cpp
+ Sparc.cpp
+ SystemZ.cpp
+ TCE.cpp
+ VE.cpp
+ WebAssembly.cpp
+ X86.cpp
+ XCore.cpp
+)
|
|
@llvm/pr-subscribers-backend-amdgpu Author: Farzon Lotfi (farzonl) Changesfixes #133199 The fix to reland was moving That change means that the files in PR #132252 Created a second file that shared <TargetName>.cpp in clang/lib/CodeGen/CMakeLists.txt For example There were two AMDGPU.cpp's one in TargetBuiltins and the other in Targets. Even though these were in different directories libtool warns that it might not distinguish them because they share the same base name. There are two potential fixes. The easy fix is to rename one of them and keep one cmake file. That solution though doesn't future proof this problem in the event of a third <TargetName>.cpp and it seems teams want to just use the target name The alternative fix is to seperate the cmake files into their own sub directories as static libs. Full diff: https://github.com/llvm/llvm-project/pull/133850.diff 4 Files Affected:
diff --git a/clang/lib/CodeGen/CMakeLists.txt b/clang/lib/CodeGen/CMakeLists.txt
index ebe2fbd7db295..2bf32a6b9d8aa 100644
--- a/clang/lib/CodeGen/CMakeLists.txt
+++ b/clang/lib/CodeGen/CMakeLists.txt
@@ -116,45 +116,10 @@ add_clang_library(clangCodeGen
PatternInit.cpp
SanitizerMetadata.cpp
SwiftCallingConv.cpp
- TargetBuiltins/ARM.cpp
- TargetBuiltins/AMDGPU.cpp
- TargetBuiltins/Hexagon.cpp
- TargetBuiltins/NVPTX.cpp
- TargetBuiltins/PPC.cpp
- TargetBuiltins/RISCV.cpp
- TargetBuiltins/SPIR.cpp
- TargetBuiltins/SystemZ.cpp
- TargetBuiltins/WebAssembly.cpp
- TargetBuiltins/X86.cpp
TargetInfo.cpp
- Targets/AArch64.cpp
- Targets/AMDGPU.cpp
- Targets/ARC.cpp
- Targets/ARM.cpp
- Targets/AVR.cpp
- Targets/BPF.cpp
- Targets/CSKY.cpp
Targets/DirectX.cpp
- Targets/Hexagon.cpp
- Targets/Lanai.cpp
- Targets/LoongArch.cpp
- Targets/M68k.cpp
- Targets/MSP430.cpp
- Targets/Mips.cpp
- Targets/NVPTX.cpp
- Targets/PNaCl.cpp
- Targets/PPC.cpp
- Targets/RISCV.cpp
- Targets/SPIR.cpp
- Targets/Sparc.cpp
- Targets/SystemZ.cpp
- Targets/TCE.cpp
- Targets/VE.cpp
- Targets/WebAssembly.cpp
- Targets/X86.cpp
- Targets/XCore.cpp
VarBypassDetector.cpp
-
+
DEPENDS
vt_gen
intrinsics_gen
@@ -170,4 +135,16 @@ add_clang_library(clangCodeGen
clangFrontend
clangLex
clangSerialization
+ clangCodeGenTargetBuiltins
+ clangCodeGenTargets
+ )
+
+ target_include_directories(clangCodeGen
+ PUBLIC
+ ${CMAKE_CURRENT_SOURCE_DIR}
+ ${CMAKE_CURRENT_SOURCE_DIR}/TargetBuiltins
+ ${CMAKE_CURRENT_SOURCE_DIR}/Targets
)
+
+ add_subdirectory(TargetBuiltins)
+ add_subdirectory(Targets)
diff --git a/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp b/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp
index b56b739094ff3..577fee05d4af6 100644
--- a/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp
+++ b/clang/lib/CodeGen/TargetBuiltins/AMDGPU.cpp
@@ -1,4 +1,4 @@
-//===------- AMDCPU.cpp - Emit LLVM Code for builtins ---------------------===//
+//===------- AMDGPU.cpp - Emit LLVM Code for builtins ---------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
diff --git a/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt b/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt
new file mode 100644
index 0000000000000..76be68a11d02a
--- /dev/null
+++ b/clang/lib/CodeGen/TargetBuiltins/CMakeLists.txt
@@ -0,0 +1,14 @@
+include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
+
+add_clang_library(clangCodeGenTargetBuiltins STATIC
+ ARM.cpp
+ AMDGPU.cpp
+ Hexagon.cpp
+ NVPTX.cpp
+ PPC.cpp
+ RISCV.cpp
+ SPIR.cpp
+ SystemZ.cpp
+ WebAssembly.cpp
+ X86.cpp
+)
diff --git a/clang/lib/CodeGen/Targets/CMakeLists.txt b/clang/lib/CodeGen/Targets/CMakeLists.txt
new file mode 100644
index 0000000000000..531a9461b7201
--- /dev/null
+++ b/clang/lib/CodeGen/Targets/CMakeLists.txt
@@ -0,0 +1,30 @@
+include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
+
+add_clang_library(clangCodeGenTargets STATIC
+ PARTIAL_SOURCES_INTENDED
+ AArch64.cpp
+ AMDGPU.cpp
+ ARC.cpp
+ ARM.cpp
+ AVR.cpp
+ BPF.cpp
+ CSKY.cpp
+ Hexagon.cpp
+ Lanai.cpp
+ LoongArch.cpp
+ M68k.cpp
+ MSP430.cpp
+ Mips.cpp
+ NVPTX.cpp
+ PNaCl.cpp
+ PPC.cpp
+ RISCV.cpp
+ SPIR.cpp
+ Sparc.cpp
+ SystemZ.cpp
+ TCE.cpp
+ VE.cpp
+ WebAssembly.cpp
+ X86.cpp
+ XCore.cpp
+)
|
|
Could you please provide some more detail on why the special DirectX handling is necessary? The commit message says something about "DirectX use of CodeGenModule as input to getHLSLType" being the reason, but I don't get why that is relevant. |
the DirectX target is why I originally added this target_link_libraries(clangCodeGenTargets
PRIVATE
clangCodeGen
)If I didn't add this I would get two linker errors and The problem is this adds a circular dependency so then all the builds with The change I have now removes the circular dependency but then forces I could maybe avoid this but then some stuff in DirectX.cpp need to be reorganized and I was trying to avoid a code change. |
|
I don't really get why that problem is specific to DirectX though. All of these make use of CodeGen, right? |
@nikic I see what you are asking. you want more specific on the error not that the error happened. because of this: llvm-project/clang/lib/CodeGen/Targets/DirectX.cpp Lines 79 to 80 in 42b3f91
I could potentially try to move If that works I'll ask @bogner or @hekota if its ok to move. |
farzonl
force-pushed
the
fix/issue-133199
branch
from
d00d246 to
e6ec9a3
Compare
farzonl
force-pushed
the
fix/issue-133199
branch
2 times, most recently
from
672a5f6 to
baf93dd
Compare
fixes llvm#133199 PR llvm#132252 Created a second file that shared <TargetName>.cpp in `clang/lib/CodeGen/CMakeLists.txt` For example There were two AMDGPU.cpp's one in TargetBuiltins and the other in Targets. Even though these were in different directories libtool warns that it might not distinguish them because they share the same base name. There are two fixes. The easy fix is to rename one of them and keep one cmake file. That solution though doesn't future proof this problem in the event of a third <TargetName>.cpp and it seems teams want to just use the target name llvm#132252 (comment). The alternative fix is to seperate the cmake files into their own sub directories. I chose to create static libraries. It might of been possible to build an OBJECT, but I only saw examples of $<TARGET_OBJECTS:> in compiler-rt and test directories so assumed there was a reason it wasn't used.
… so it has to be compiled in clang/lib/CodeGen/CMakeLists.txt. This means clangCodeGenTargets needs to be PARTIAL_SOURCES_INTENDED. or clang/lib/CodeGen/Targets/DirectX.cpp needs to be moved to a different directory.
…b/CodeGen/Targets fixes things so we don't need PARTIAL_SOURCES_INTENDED and don't need to special case into the clangcodegen library
farzonl
force-pushed
the
fix/issue-133199
branch
from
baf93dd to
b45f903
Compare
|
Awesome Thanks Helena! @nikic are you happy with the state of this change for relanding this PR? |
|
I'm still somewhat confused about why that one file in particular is problematic, but I guess if this works it's fine. Would making these OBJECT instead of STATIC libraries avoid the issue perhaps? |
No OBJECT seems to cause many more linker errors. So i'm going to stick with the current solution and merge in the morning if there are no other concerns. ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitARMBuiltinExpr(unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)
>>> referenced by CGBuiltin.cpp:65 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:65)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitAArch64BuiltinExpr(unsigned int, clang::CallExpr const*, llvm::Triple::ArchType)
>>> referenced by CGBuiltin.cpp:69 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:69)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitBPFBuiltinExpr(unsigned int, clang::CallExpr const*)
>>> referenced by CGBuiltin.cpp:72 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:72)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitX86BuiltinExpr(unsigned int, clang::CallExpr const*)
>>> referenced by CGBuiltin.cpp:75 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:75)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitPPCBuiltinExpr(unsigned int, clang::CallExpr const*)
>>> referenced by CGBuiltin.cpp:80 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:80)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned int, clang::CallExpr const*)
>>> referenced by CGBuiltin.cpp:83 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:83)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
>>> referenced by CGBuiltin.cpp:102 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:102)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitSystemZBuiltinExpr(unsigned int, clang::CallExpr const*)
>>> referenced by CGBuiltin.cpp:85 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:85)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitNVPTXBuiltinExpr(unsigned int, clang::CallExpr const*)
>>> referenced by CGBuiltin.cpp:88 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:88)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitWebAssemblyBuiltinExpr(unsigned int, clang::CallExpr const*)
>>> referenced by CGBuiltin.cpp:91 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:91)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitHexagonBuiltinExpr(unsigned int, clang::CallExpr const*)
>>> referenced by CGBuiltin.cpp:93 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:93)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitRISCVBuiltinExpr(unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot)
>>> referenced by CGBuiltin.cpp:96 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:96)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitSPIRVBuiltinExpr(unsigned int, clang::CallExpr const*)
>>> referenced by CGBuiltin.cpp:98 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:98)
>>> CGBuiltin.cpp.o:(EmitTargetArchBuiltinExpr(clang::CodeGen::CodeGenFunction*, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot, llvm::Triple::ArchType)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitScalarOrConstFoldImmArg(unsigned int, unsigned int, clang::CallExpr const*)
>>> referenced by CGBuiltin.cpp:6050 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGBuiltin.cpp:6050)
>>> CGBuiltin.cpp.o:(clang::CodeGen::CodeGenFunction::EmitBuiltinExpr(clang::GlobalDecl, unsigned int, clang::CallExpr const*, clang::CodeGen::ReturnValueSlot)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenModule::handleCUDALaunchBoundsAttr(llvm::Function*, clang::CUDALaunchBoundsAttr const*, int*, int*, int*)
>>> referenced by CGOpenMPRuntime.cpp:5885 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGOpenMPRuntime.cpp:5885)
>>> CGOpenMPRuntime.cpp.o:(clang::CodeGen::CGOpenMPRuntime::computeMinAndMaxThreadsAndTeams(clang::OMPExecutableDirective const&, clang::CodeGen::CodeGenFunction&, llvm::OpenMPIRBuilder::TargetKernelDefaultAttrs&)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenModule::handleAMDGPUFlatWorkGroupSizeAttr(llvm::Function*, clang::AMDGPUFlatWorkGroupSizeAttr const*, clang::ReqdWorkGroupSizeAttr const*, int*, int*)
>>> referenced by CGOpenMPRuntime.cpp:5888 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGOpenMPRuntime.cpp:5888)
>>> CGOpenMPRuntime.cpp.o:(clang::CodeGen::CGOpenMPRuntime::computeMinAndMaxThreadsAndTeams(clang::OMPExecutableDirective const&, clang::CodeGen::CodeGenFunction&, llvm::OpenMPIRBuilder::TargetKernelDefaultAttrs&)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenModule::handleAMDGPUWavesPerEUAttr(llvm::Function*, clang::AMDGPUWavesPerEUAttr const*)
>>> referenced by CGOpenMPRuntime.cpp:5937 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGOpenMPRuntime.cpp:5937)
>>> CGOpenMPRuntime.cpp.o:(clang::CodeGen::CGOpenMPRuntime::emitTargetOutlinedFunctionHelper(clang::OMPExecutableDirective const&, llvm::StringRef, llvm::Function*&, llvm::Constant*&, bool, clang::CodeGen::RegionCodeGenTy const&)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::computeSPIRKernelABIInfo(clang::CodeGen::CodeGenModule&, clang::CodeGen::CGFunctionInfo&)
>>> referenced by CGCall.cpp:844 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CGCall.cpp:844)
>>> CGCall.cpp.o:(clang::CodeGen::CodeGenTypes::arrangeLLVMFunctionInfo(clang::CanQual<clang::Type>, clang::CodeGen::FnInfoOpts, llvm::ArrayRef<clang::CanQual<clang::Type>>, clang::FunctionType::ExtInfo, llvm::ArrayRef<clang::FunctionType::ExtParameterInfo>, clang::CodeGen::RequiredArgs)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitAArch64CpuSupports(llvm::ArrayRef<llvm::StringRef>)
>>> referenced by CodeGenFunction.cpp:2881 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CodeGenFunction.cpp:2881)
>>> CodeGenFunction.cpp.o:(clang::CodeGen::CodeGenFunction::FormAArch64ResolverCondition(clang::CodeGen::CodeGenFunction::FMVResolverOption const&)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitX86CpuSupports(llvm::ArrayRef<llvm::StringRef>)
>>> referenced by CodeGenFunction.cpp:2893 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CodeGenFunction.cpp:2893)
>>> CodeGenFunction.cpp.o:(clang::CodeGen::CodeGenFunction::FormX86ResolverCondition(clang::CodeGen::CodeGenFunction::FMVResolverOption const&)) in archive lib/libclangCodeGen.a
>>> referenced by CodeGenFunction.cpp:2899 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CodeGenFunction.cpp:2899)
>>> CodeGenFunction.cpp.o:(clang::CodeGen::CodeGenFunction::FormX86ResolverCondition(clang::CodeGen::CodeGenFunction::FMVResolverOption const&)) in archive lib/libclangCodeGen.a
ld.lld: error: undefined symbol: clang::CodeGen::CodeGenFunction::EmitX86CpuIs(llvm::StringRef)
>>> referenced by CodeGenFunction.cpp:2895 (/mnt/DevDrive/projects/llvm-project/clang/lib/CodeGen/CodeGenFunction.cpp:2895)
>>> CodeGenFunction.cpp.o:(clang::CodeGen::CodeGenFunction::FormX86ResolverCondition(clang::CodeGen::CodeGenFunction::FMVResolverOption const&)) in archive lib/libclangCodeGen.a
ld.lld: error: too many errors emitted, stopping now (use --error-limit=0 to see all errors)
clang++: error: linker command failed with exit code 1 (use -v to see invocation) |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/2955 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/5686 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/5664 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/203/builds/6873 Here is the relevant piece of the build log for the reference |
farzonl
added a commit
that referenced
this pull request
Apr 7, 2025
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Apr 7, 2025
… name warnings" (#134656) Reverts llvm/llvm-project#133850
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/80/builds/12287 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/130/builds/12053 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #133199
As of the third commit the fix to the linker missing references in
Targets/DirectX.cppfound in #133776 was fixed by movingHLSLBufferLayoutBuilder.cpptoclang/lib/CodeGen/Targets/.It fixes the circular reference issue found in #133619 for all
-DBUILD_SHARED_LIBS=ONbuilds by removingtarget_link_librariesfrom the sub directory cmake files.testing for amdgpu offload was done via
cmake -B ../llvm_amdgpu -S llvm -GNinja -C offload/cmake/caches/Offload.cmake -DCMAKE_BUILD_TYPE=ReleasePR #132252 Created a second file that shared .cpp in clang/lib/CodeGen/CMakeLists.txt
For example There were two AMDGPU.cpp's one in TargetBuiltins and the other in Targets. Even though these were in different directories libtool warns that it might not distinguish them because they share the same base name.
There are two potential fixes. The easy fix is to rename one of them and keep one cmake file. That solution though doesn't future proof this problem in the event of a third .cpp and it seems teams want to just use the target name
#132252 (comment).
The alternative fix that this PR went with is to seperate the cmake files into their own sub directories as static libs.